Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call the right method to convert table from row major <=> col major [databricks] #3762

Merged
merged 10 commits into from
Jan 13, 2022
Merged

Call the right method to convert table from row major <=> col major [databricks] #3762

merged 10 commits into from
Jan 13, 2022

Conversation

razajafri
Copy link
Collaborator

@razajafri razajafri commented Oct 6, 2021 •
edited
Loading

This is a draft PR that depends on rapidsai/cudf#8444

  • Added logic to branch the code based on the number of columns selected while convert from Columnar to Row and back
  • Added test to test the new method which will handle columns > 100

closes #3761

@razajafri
Call the appropriate method for row<->col conversion
ad9a072 
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri razajafri changed the base branch from branch-21.10 to branch-21.12 October 6, 2021 23:13
@sameerz sameerz added the task Work required that improves the product but is not user facing label Oct 7, 2021
@sameerz sameerz added this to the Oct 4 - Oct 15 milestone Oct 7, 2021
@razajafri
copy offsets data per row
7c0b88a 
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri
debug
7b310e9 
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri
Revert "debug"
8eca9c8 
This reverts commit 7b310e9.

Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri
remove println
c3dc5bd 
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri
fixed typo
fbb0a8f 
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri razajafri changed the base branch from branch-21.12 to branch-22.02 November 15, 2021 17:36
@razajafri
Merge remote-tracking branch 'origin/branch-22.02' into HEAD
0ad1f3c 
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri
Insert a check for rows < 1
390ec7d 
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri razajafri marked this pull request as ready for review January 11, 2022 04:39
@razajafri razajafri changed the title Call the right method to convert table from row major <=> col major Call the right method to convert table from row major <=> col major [databricks] Jan 11, 2022
@razajafri
Copy link
Collaborator Author

build

@razajafri
update copyrights
e88170b 
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri
Copy link
Collaborator Author

The cudf nightly failed today which should be fixed by rapidsai/cudf#10015. Will kick off the build tomorrow if the nightly is successful

@razajafri
removed the extra parameter and calculate the branch variable right b…
e3726fc 
…efore the branching

Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri
Copy link
Collaborator Author

build

@razajafri razajafri merged commit f1be1a5 into NVIDIA:branch-22.02 Jan 13, 2022
@razajafri razajafri deleted the SP-3761-row-col-conv branch January 13, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

Assignees

@razajafri razajafri

Labels
task Work required that improves the product but is not user facing
Projects
None yet
Milestone
Jan 10 - Jan 28
Development

Successfully merging this pull request may close these issues.

[FEA] Call the appropriate method when transitioning from Row<=>Col
3 participants
@razajafri @revans2 @sameerz