Add Rlike support #3796
Merged
Add Rlike support #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
razajafri
reviewed
Oct 12, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Closed
revans2
reviewed
Oct 18, 2021
| val pattern = if (rhs.isValid) { | ||
| rhs.getValue.asInstanceOf[UTF8String].toString | ||
| } else { | ||
| null |
There was a problem hiding this comment.
It does not look like we have tested the null case. Does CUDF do the correct thing in these cases?
There was a problem hiding this comment.
It looks like the null path can't be hit here. If I test with expr RLIKE null then the rlike expression itself is optimized out of the plan and replaced with a null literal. Also, we only attempt to run on GPU if the rhs is a Literal. Are there any cases here where isValid could be false? If not, perhaps I should remove this conditional?
There was a problem hiding this comment.
I would keep the conditional and throw an exception instead with an explanation about how this is never reached. Just to be defensive.
Signed-off-by: Andy Grove <andygrove@nvidia.com>
revans2
approved these changes
Oct 18, 2021
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2.
This PR implements the
RLikeexpression which works by calling cuDF'scontains_refunction.There are a number of known issues where results are not consistent with Apache Spark and these are documented in the compatibility guide.
The feature is disabled by default.
I have filed a follow-on issue #3797 for improving the support.