Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable rlike integration tests on Databricks #3867

Merged
merged 3 commits into from
Oct 21, 2021

Conversation

andygrove
Copy link
Contributor

@andygrove andygrove commented Oct 20, 2021

Signed-off-by: Andy Grove andygrove@nvidia.com

Disabling tests due to failures on Azure Databricks 7.3

Related to #3866

Signed-off-by: Andy Grove <andygrove@nvidia.com>
@andygrove andygrove added bug Something isn't working build Related to CI / CD or cleanly building labels Oct 20, 2021
@andygrove andygrove added this to the Oct 18 - Oct 29 milestone Oct 20, 2021
@andygrove andygrove self-assigned this Oct 20, 2021
@andygrove
Copy link
Contributor Author

build

@tgravescs
Copy link
Collaborator

Note, we don't want to close ehttps://github.com//issues/3866 if that is referenced from xfail

@@ -451,6 +451,7 @@ def test_like_complex_escape():
'a like "_oo"'),
conf={'spark.sql.parser.escapedStringLiterals': 'true'})

@pytest.mark.xfail(reason='Fails on Azure Databricks 7.3 - https://github.com/NVIDIA/spark-rapids/issues/3866')
Copy link
Collaborator

@tgravescs tgravescs Oct 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing here is that if it only fails on Databricks could use:

pytest.mark.xfail(is_databricks_runtime(), reason=..

Copy link
Contributor Author

@andygrove andygrove Oct 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I didn't know that we had that capability.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss one here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, tagged the wrong one. Fixed.

@andygrove
Copy link
Contributor Author

build

@andygrove andygrove changed the title Disable rlike integration tests Disable rlike integration tests on Databricks Oct 21, 2021
@tgravescs tgravescs merged commit b1fae3f into NVIDIA:branch-21.12 Oct 21, 2021
@andygrove andygrove deleted the disable-rlike-tests branch November 30, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants