Fix incorrect schema of nested types of union - audit SPARK-36673 #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
|
build |
|
build |
nartal1
previously approved these changes
Oct 20, 2021
...lugin/src/main/301until320-all/scala/org/apache/spark/sql/execution/ShimTrampolineUtil.scala
Outdated
Show resolved
Hide resolved
|
build |
nartal1
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3836
This is an audit issue. The actual bug is handled by Spark side where it deals with the schema, but bring our code in sync with it. Here we have Trampoline code that was version specific so I created a ShimTrampolineUtil. I called that from the TrampolineUtil with the idea that user calls to one place and can go one place to find things easily, but if people have opinions on this we could just call into the ShimTrampolineUtil.
Signed-off-by: Thomas Graves tgraves@nvidia.com