Add version properties to integration tests modules #3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peixin Li <pxli@nyu.edu>
|
build |
tgravescs
previously approved these changes
Oct 25, 2021
jlowe
reviewed
Oct 25, 2021
udf-examples/pom.xml
Outdated
| @@ -74,6 +74,32 @@ | |||
| </resource> | |||
| </resources> | |||
| <plugins> | |||
| <plugin> | |||
There was a problem hiding this comment.
This should be getting picked up by the pluginManagement section of the parent pom. I verified that removing the change to this file doesn't seem to affect the contents of the udf-examples jar.
There was a problem hiding this comment.
nice catch, thx! removed
|
build |
NvTimLiu
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peixin Li pxli@nyu.edu
related to #3652
It's difficult to fetch artifacts by git commit from maven repo.
let's add build info to all artifacts in integration tests for better debugging context first,
and I will try adjust our nightly build triggering graph later