Stop using -U in the build that merges all aggregator jars #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
abellina
requested review from
GaryShen2008,
jlowe,
NvTimLiu,
revans2 and
tgravescs
as code owners
|
build |
jlowe
reviewed
Oct 25, 2021
abellina
changed the title
|
build |
jlowe
reviewed
Oct 25, 2021
jlowe
approved these changes
Oct 25, 2021
gerashegalov
approved these changes
Oct 25, 2021
tgravescs
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alessandro Bellina abellina@nvidia.com
Fixes a race condition in the pre-merge build, where an aggregator jar would be built and installed to the local .m2 and later on disregarded if a nightly job happened to be running at the same time and published a newer (in time) version of the same artifact jar.
Prior to this the
-U(--update-snapshots) flag was being passed to the last stage of the build, where all the aggregator jars were getting combined. At this point, a newer aggregator jar could be fetched from remote. We removed the-Uflag to prevent this from happening in the future.