Qualification tool: Detect JDBCRelation in eventlog #3937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
|
build |
tgravescs
reviewed
Oct 28, 2021
There was a problem hiding this comment.
so while this works, this is really just another Scan and we already have logic in there for dealing with FileScans and read file formats. I don't see why this couldn't follow the same logic and be included in the score like we do for those.
it would end up being placed under the "Unsupported Read File Formats and Types" column so user could still see it and this way it actually changes score as well. @viadea you requested this, so any issues with that?
tools/src/test/scala/com/nvidia/spark/rapids/tool/qualification/QualificationSuite.scala
Show resolved
Hide resolved
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
|
build |
|
@tgravescs PTAL |
tgravescs
reviewed
Nov 8, 2021
tools/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualificationAppInfo.scala
Show resolved
Hide resolved
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
|
build |
tgravescs
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3432 . It scans for JDBCRelation in eventlog and marks as potential problem. Added test to verify.