Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back AST support for BNLJ inner joins #3967

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Bring back AST support for BNLJ inner joins #3967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions ...main/scala/org/apache/spark/sql/rapids/execution/GpuBroadcastNestedLoopJoinExecBase.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,7 @@ class GpuBroadcastNestedLoopJoinMeta(
verifyBuildSideWasReplaced(buildSide)

val condition = conditionMeta.map(_.convertToGpu())
val isAstCondition = join.joinType match {
case _: InnerLike =>
// It appears to be faster to manifest the full cross join and post-filter than
// evaluate the AST during the join.
false
case _ => conditionMeta.forall(_.canThisBeAst)
}
val isAstCondition = conditionMeta.forall(_.canThisBeAst)
join.joinType match {
case _: InnerLike =>
case LeftOuter | LeftSemi | LeftAnti if gpuBuildSide == GpuBuildLeft =>
Expand Down