Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the catalystConverter to be a Scala val. #4038

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Change the catalystConverter to be a Scala val. #4038

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2fec02
Change the catalystConverter to be a `val`.
firestarman Nov 5, 2021
3615b49
Address the comments
firestarman Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuScalaUDF.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ abstract class GpuRowBasedScalaUDFBase(
* converter for typed ScalaUDF only, since its the only case where we know the type tag
* of the return data type of udf function.
*/
private def catalystConverter: Any => Any = outputEncoder.map { enc =>
private[this] lazy val catalystConverter: Any => Any = outputEncoder.map { enc =>
val toRow = enc.createSerializer().asInstanceOf[Any => Any]
if (enc.isSerializedAsStructForTopLevel) {
value: Any =>
Expand Down