-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Databricks image from 8.2 to 9.1 [skip ci] #4049
Conversation
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this change includes the jenkinsfile change, so it would possibly failed the test and we may need to skip ci here, can you test against https://github.com/pxLi/spark-rapids/ repo?
@@ -390,7 +390,7 @@ pipeline { | |||
} | |||
} // end of DB runtime 7.3 | |||
|
|||
stage('DB runtime 8.2') { | |||
stage('DB runtime 9.1') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also update stage expression,
db_build && major_ver >= 21 && minor_ver >= 6
==>
db_build && major_ver >= 21 && minor_ver >= 12
as we added spark312db shim later for 21.12 or later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
build |
@tgravescs @jlowe @revans2 Could you please help to review? Thanks! Please keep this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, but I am not the databricks expert so I will not approve this until someone else with more experience takes a look too.
Converting this to a draft PR so it cannot be accidentally merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be done separately but it would be nice to update the jenkins/databricks/build.sh and test.sh script to default to 9.1.
@NvTimLiu has this been tested? |
${base}/envs/mamba/bin/mamba install -y -c rapidsai -c rapidsai-nightly -c nvidia -c conda-forge -c defaults cudf=$CUDF_VER cudatoolkit=11.0 | ||
conda env remove -n mamba | ||
# Create and activate 'cudf-udf' conda env for cudf-udf tests | ||
conda create -y -n cudf-udf && source activate && conda activate cudf-udf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We change to create a common 'cudf-udf' conda environment for cudf udf tests, because
1, Not like 7.3 & 8.2, Databricks 9.1 does not have the default databricks-ml-gpu
conda ENV
2, In 7.3 & 8.2, the script init_cudf_udf.sh create the empty MAMBA conda environment, but install everything (using MAMBA)into the default databricks-ml-gpu
ENV, this looks odd.
3, We create a common and clean cudf-udf
ENV specified for the cudf udf test.
Yes, this has been tested against both 7.3 & 9.1 build/IT runtime. On 7.3, got everything PASS, On 9.1, FAILED on the issue: rapidsai/cudf#9622 Will verify after the issue get fixed. |
[[ -z $SPARK_SHIM_VER ]] && export SPARK_SHIM_VER=spark${BASE_SPARK_VER//.}db | ||
|
||
# Try to use "cudf-udf" conda environment for the python cudf-udf tests. | ||
if [ -d "/databricks/conda/envs/cudf-udf" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use "cudf-udf" conda environment (created by jenkins/databricks/init_cudf_udf.sh) for the python cudf-udf tests.
Databricks 8.2 has been deprecated, change to Databricks 9.1 LTS. Signed-off-by: Tim Liu <timl@nvidia.com>
Signed-off-by: Tim Liu <timl@nvidia.com>
Signed-off-by: Tim Liu <timl@nvidia.com>
DB 9.1 tests failed on #4069 |
build |
Going to create a dummy verification PR |
Databricks 8.2 has been deprecated, change to Databricks 9.1 LTS.
Signed-off-by: Tim Liu timl@nvidia.com