Fix overflow checking on optimized decimal sum #4072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
jlowe
approved these changes
Nov 10, 2021
kuhushukla
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this yesterday while trying to check a few things with overflow on the decimal 128 branch. It turns out the underflow, and wrapped overflow were not being checked properly. I have fixed it, but the test would take a very long time to run and I am not sure we want to put into into our regular integration tests
The changes for
GpuUnscaledValueare there mostly to get the test to work. It turns out that UnscaledValue is applied after constant folding so if you have a Decimal constant value with precision 8 or lower that you are doing a SUM on it will not run on the GPU. It is a bit of a corner case. The changes forGpuUnscaledValuewere already applied to the decimal128 support branch.