Add abfs and abfss to the cloud scheme #4082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bobby Wang <wbo4958@gmail.com>
|
build |
jlowe
reviewed
Nov 11, 2021
| "generally would be total separate from the executors and likely have a higher I/O read " + | ||
| "cost. Many times the cloud filesystems also get better throughput when you have multiple " + | ||
| "readers in parallel. This is used with spark.rapids.sql.format.parquet.reader.type") | ||
| "filesystems. Schemes already included: dbfs, s3, s3a, s3n, wasbs, gs, abfs, abfss. Cloud " + |
There was a problem hiding this comment.
Nit: It would be nice to not have to keep these manually in-sync, and also would be nice to list them alphabetically. For example, moving the default cloud scheme list from GpuMultiFileReader to here with something like:
/** List of schemes that are always considered cloud storage schemes */
val DEFAULT_CLOUD_SCHEMES = Seq("abfs", "abfss", "dbfs", "gs", "s3", "s3a", "s3n", "wasbs")
val CLOUD_SCHEMES = conf("spark.rapids.cloudSchemes")
[...]
s"filesystems. Schemes already included: ${DEFAULT_CLOUD_SCHEMES.mkString(", ")}. Cloud " +Then GpuMultiFileReader can create its cloud schemes HashSet from the list in RapidsConf.
jlowe
previously approved these changes
Nov 11, 2021
|
did we run any perf tests on this just to make sure this performed better? |
|
build |
I just did the perf test locally for COALESCING and cloud reading for total 1.3G and 5000 orc files residing in Azure.
|
tgravescs
approved these changes
Nov 12, 2021
jlowe
approved these changes
Nov 12, 2021
|
build |
sameerz
added
the
task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bobby Wang wbo4958@gmail.com