Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler warning in regex transpiler #4083

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Fix compiler warning in regex transpiler #4083

merged 1 commit into from
Nov 11, 2021

Conversation

andygrove
Copy link
Contributor

Signed-off-by: Andy Grove andygrove@nvidia.com

This is required to fix the pre-merge build for #4071 although that PR will likely need upmerging as well since RegexParser::transpile has been substantially refactored recently.

@andygrove
Fix compiler warning in regex transpiler
df08304 
Signed-off-by: Andy Grove <andygrove@nvidia.com>
@andygrove andygrove mentioned this pull request Nov 11, 2021
Merged
@andygrove
Copy link
Contributor Author

build

gerashegalov
gerashegalov approved these changes Nov 11, 2021
View reviewed changes
Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove andygrove merged commit bae98dc into NVIDIA:branch-21.12 Nov 11, 2021
@andygrove andygrove deleted the regex-match-error branch November 11, 2021 18:11
@pxLi pxLi added the bug Something isn't working label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerashegalov gerashegalov gerashegalov approved these changes

@revans2 revans2 revans2 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andygrove @gerashegalov @revans2 @pxLi