Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAPIDS Shuffle Manager fallback if security is enabled #4231

Merged

Conversation

abellina
Copy link
Collaborator

Signed-off-by: Alessandro Bellina abellina@nvidia.com

Closes #4227.

This falls back the RAPIDS Shuffle Manager if RPC authentication or network encryption are requested.

Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
revans2
revans2 previously approved these changes Nov 29, 2021
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 but I would like to hear from a few more people to be sure this looks like enough.

@abellina
Copy link
Collaborator Author

build

Copy link
Collaborator

@jbrennan333 jbrennan333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lgtm

@abellina
Copy link
Collaborator Author

build

@abellina abellina merged commit ae9c120 into NVIDIA:branch-21.12 Nov 30, 2021
@pxLi pxLi added bug Something isn't working shuffle things that impact the shuffle plugin labels Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working shuffle things that impact the shuffle plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] RAPIDS Shuffle Manager doesn't fallback given encryption settings
6 participants