Sanitize column names in ParquetCachedBatchSerializer before writing to Parquet [databricks] #4258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
|
build |
|
build |
|
can you create, reference an issue that is being solved by this PR? |
gerashegalov
reviewed
Dec 2, 2021
| // We want to change the original schema to have the new names as well | ||
| private def sanitizeColumnNames(originalSchema: Seq[Attribute], | ||
| schemaToCopyNamesFrom: Seq[Attribute]): Seq[Attribute] = { | ||
| originalSchema.zip(schemaToCopyNamesFrom).map(t => t._1.withName(t._2.name)) |
There was a problem hiding this comment.
nit: prefer pattern-match to _1, _2, e.g.:
originalSchema.zip(schemaToCopyNamesFrom).map {
case (origAttr, newAttr) => origAttr.withName(newAttr.name)
}
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
|
build |
jlowe
previously approved these changes
Dec 6, 2021
mythrocks
reviewed
Dec 6, 2021
.../src/main/311+-all/scala/com/nvidia/spark/rapids/shims/v2/ParquetCachedBatchSerializer.scala
Outdated
Show resolved
Hide resolved
mythrocks
requested changes
Dec 6, 2021
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
mythrocks
approved these changes
Dec 6, 2021
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a case where we use the original schema sent by Spark which has names that haven't been
sanitized.This PR sets the names before creating a Hadoop conf.
Signed-off-by: Raza Jafri rjafri@nvidia.com