Split expensive pytest files in cases level [skip ci] #4336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peixin Li <pxli@nyu.edu>
pxLi
requested review from
GaryShen2008,
jlowe,
NvTimLiu,
revans2 and
tgravescs
as code owners
revans2
previously approved these changes
Dec 9, 2021
| # --halt "now,fail=1": exit when the first job fail, and kill running jobs. | ||
| # we can set it to "never" and print failed ones after finish running all tests if needed | ||
| # --group: print stderr after test finished for better readability | ||
| parallel --group --halt "now,fail=1" -j2 run_test ::: ${mem_consuming_cases} | ||
|
|
||
| time_consuming_tests_str=$(echo ${time_consuming_tests} | xargs | sed 's/ / or /g') |
There was a problem hiding this comment.
Would it be better to have a tag for these tests?
There was a problem hiding this comment.
Would also be good if we could document better some place about these things
There was a problem hiding this comment.
Would it be better to have a tag for these tests?
Yes, tag would be better here. Let me add some +TODO, and I will add some tags here if we see more cases in this category
tgravescs
reviewed
Dec 9, 2021
jenkins/spark-tests.sh
Outdated
| if [[ $PARALLEL_TEST == "true" ]] && [ -x "$(command -v parallel)" ]; then | ||
| cache_test_cases=$(./run_pyspark_from_build.sh -k "cache_test" \ | ||
| --collect-only -qq 2>/dev/null | grep -oP '(?<=::).*?(?=\[)' | uniq | shuf | xargs) | ||
| # hardcode parallelism as 4 |
There was a problem hiding this comment.
comment looks wrong, using -j5 below
tgravescs
approved these changes
Dec 10, 2021
|
build |
|
created #4348 to follow tagging updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peixin Li pxli@nyu.edu
fix #3279
Verified in multiple scenarios, saved around ~15 mins (30x) and 30 mins (311+) comparing to current setup