Fix issue with binding to hash agg columns with computation [databricks] #4343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
abellina
approved these changes
Dec 10, 2021
| @@ -679,7 +686,7 @@ class GpuHashAggregateIterator( | |||
|
|
|||
| // a bound expression that is applied before the cuDF aggregate | |||
| private val preStepBound = if (forceMerge) { | |||
| GpuBindReferences.bindGpuReferences(preStep, aggBufferAttributes) | |||
| GpuBindReferences.bindGpuReferences(preStep.toList, aggBufferAttributes.toList) | |||
There was a problem hiding this comment.
nit, do we need the toList here?
|
build |
|
The CI failure was due to cudf missing a dynamic link dependency. Should be fixed by rapidsai/cudf#9890. |
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where on older versions of Spark the hash aggregate included computation binding was wrong. This was introduced by #4272