Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with InSet and Strings #437

Merged
merged 2 commits into from
Jul 27, 2020

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Jul 27, 2020

This fixes #433

Literal.apply does not work if the value is a UTF8String. This fixes that issue.

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@revans2 revans2 added the bug Something isn't working label Jul 27, 2020
@revans2 revans2 added this to the Jul 20 - Jul 31 milestone Jul 27, 2020
@revans2 revans2 self-assigned this Jul 27, 2020
@revans2
Copy link
Collaborator Author

revans2 commented Jul 27, 2020

build

integration_tests/src/main/python/cmp_test.py Outdated Show resolved Hide resolved
integration_tests/src/main/python/cmp_test.py Outdated Show resolved Hide resolved
integration_tests/src/main/python/cmp_test.py Outdated Show resolved Hide resolved
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@revans2
Copy link
Collaborator Author

revans2 commented Jul 27, 2020

build

@revans2
Copy link
Collaborator Author

revans2 commented Jul 27, 2020

@abellina any more concerns?

Copy link
Collaborator

@abellina abellina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @revans2

@abellina abellina merged commit 48b2aab into NVIDIA:branch-0.2 Jul 27, 2020
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Fix bug with InSet and Strings

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>

* Addressed review comments

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Fix bug with InSet and Strings

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>

* Addressed review comments

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
pxLi pushed a commit to pxLi/spark-rapids that referenced this pull request May 12, 2022
…DIA#437)

* Add Ditto helper to app_common, update prostate example learners

* Correct a bug in local valid

* refactor DittoHelper

* remove a redundant lr in DittoHelper

* remove a redundant lr in DittoHelper

* remove a redundant lr in DittoHelper

* format adjustment

* refactor Ditto helper with abstract method

* further touchups on ditto helper class and supervised learner

* add type hint and check with default
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
[auto-merge] bot-auto-merge-branch-22.08 to branch-22.10 [skip ci] [bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InSet operator produces an error for Strings
3 participants