Simplified the construction of zero scalar in GpuUnaryMinus #4482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
|
build |
jlowe
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
I think this is a dubious change, but I'm not going to block it. We're changing code that creates minimal garbage (only the necessary Scalar instance) and performs minimal checks to code that creates intermediate garbage (minimally a Decimal instance) along with a bunch of extra runtime-only dispatching type checks to determine what we already knew at the calling site. Given this isn't per-row it's not egregious.
sameerz
added
the
task
…al_scalar_construction
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sperlingxx lovedreamf@gmail.com
Closes #2076