Support BitLength and OctetLength #4611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
jlowe
changed the title
jlowe
previously approved these changes
Jan 24, 2022
revans2
reviewed
Jan 24, 2022
sql-plugin/src/main/330+/scala/com/nvidia/spark/rapids/shims/v2/Spark33XShims.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/330+/scala/com/nvidia/spark/rapids/shims/v2/Spark33XShims.scala
Outdated
Show resolved
Hide resolved
|
build |
jlowe
reviewed
Jan 27, 2022
Comment on lines
405
to
406
| @pytest.mark.skipif(is_before_spark_330(), | ||
| reason="octet_length and bit_length only available in 330+") |
There was a problem hiding this comment.
Suggested change
| @pytest.mark.skipif(is_before_spark_330(), | |
| reason="octet_length and bit_length only available in 330+") |
Also should remove the (now unnecessary) import change.
There was a problem hiding this comment.
Yes, it was removed now.
|
build |
|
build |
jlowe
previously approved these changes
Jan 28, 2022
revans2
requested changes
Jan 28, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala
Outdated
Show resolved
Hide resolved
|
build |
revans2
approved these changes
Feb 7, 2022
|
@tgravescs do you plan on handling updating the 2.x explain or do we need to start enforcing it on new PRs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sperlingxx lovedreamf@gmail.com
Closes #4142
This PR is to provide GPU overrides for Spark SQL functions:
BitLengthandOctetLength