Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize and fix Api validation script #466

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

nartal1
Copy link
Collaborator

@nartal1 nartal1 commented Jul 29, 2020

Signed-off-by: Niranjan Artal nartal@nvidia.com

This closes #240.
Updated the Api validation script to fix package names after shim layer was introduced. As of now the script audits Spark 3.0 version. Have filed follow-on issue #465 to support multiple Spark versions.

Signed-off-by: Niranjan Artal <nartal@nvidia.com>
@nartal1 nartal1 added this to the Jul 20 - Jul 31 milestone Jul 29, 2020
@nartal1 nartal1 self-assigned this Jul 29, 2020
@nartal1 nartal1 added the feature request New feature or request label Jul 29, 2020
@nartal1
Copy link
Collaborator Author

nartal1 commented Jul 29, 2020

build

@nartal1 nartal1 changed the title Optimize script and fix script Optimize and fix script Jul 29, 2020
@tgravescs
Copy link
Collaborator

can we have the title and description state which script is being updated?

@nartal1 nartal1 changed the title Optimize and fix script Optimize and fix Api validation script Jul 30, 2020
@nartal1
Copy link
Collaborator Author

nartal1 commented Jul 30, 2020

@tgravescs Sorry it was too vague. Have updated the title and description. Please take another look.

Copy link
Collaborator

@kuhushukla kuhushukla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. looks good.

@razajafri
Copy link
Collaborator

Looks good

@razajafri razajafri merged commit 5d1d8ac into NVIDIA:branch-0.2 Aug 3, 2020
nartal1 added a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Optimize  script and  fix script

Signed-off-by: Niranjan Artal <nartal@nvidia.com>

* remove extra whitespaces
nartal1 added a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Optimize  script and  fix script

Signed-off-by: Niranjan Artal <nartal@nvidia.com>

* remove extra whitespaces
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Audit Api validation script follow on - Optimize StringToTypeTag
6 participants