-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize and fix Api validation script #466
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
build |
revans2
approved these changes
Jul 30, 2020
can we have the title and description state which script is being updated? |
nartal1
changed the title
Optimize and fix script
Optimize and fix Api validation script
Jul 30, 2020
@tgravescs Sorry it was too vague. Have updated the title and description. Please take another look. |
kuhushukla
approved these changes
Jul 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool. looks good.
Looks good |
nartal1
added a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Optimize script and fix script Signed-off-by: Niranjan Artal <nartal@nvidia.com> * remove extra whitespaces
nartal1
added a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Optimize script and fix script Signed-off-by: Niranjan Artal <nartal@nvidia.com> * remove extra whitespaces
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Niranjan Artal nartal@nvidia.com
This closes #240.
Updated the Api validation script to fix package names after shim layer was introduced. As of now the script audits Spark 3.0 version. Have filed follow-on issue #465 to support multiple Spark versions.