Decrease nighlty tests upper limitation to 7 [skip ci] #4701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxLi
added
bug
pxLi
requested review from
GaryShen2008,
jlowe,
NvTimLiu,
revans2 and
tgravescs
as code owners
Signed-off-by: Peixin Li <pxli@nyu.edu>
pxLi
force-pushed
the
decrease-nightly-parallelism-upper-limit-7
branch
from
3a1aa1b
to
ecbd8cc
Compare
pxLi
changed the title
|
build |
GaryShen2008
approved these changes
Feb 7, 2022
pxLi
changed the title
|
I'm a bit unclear by the description here, decreasing the parallelism makes it faster why? We are allowing more gpu memory and not spilling as much? |
Per the test results, its not always the larger parallelism, the faster total tests run. Even we have more gpu mem to split tests, the parallel run could much slower when too many cases were sharing the cuda cores (competing the SM? context switching? sry, I am not a cuda expert) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peixin Li pxli@nyu.edu
fix #4675, 8 as the upper bound of parallelism is not good any more. Decrease it to 7 to save around 40-60 mins