Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some broken links in dev branch-22.02 [skip ci] #4743

Closed
wants to merge 75 commits into from
Closed

fix some broken links in dev branch-22.02 [skip ci] #4743

wants to merge 75 commits into from

Conversation

nvliyuan
Copy link
Collaborator

fix some broken links in dev branch 2204

nvauto and others added 30 commits January 17, 2022 14:23
@nvauto
Merge pull request NVIDIA#4544 from NVIDIA/branch-22.02
6da20b7 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4546 from NVIDIA/branch-22.02
b4722ea 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4550 from NVIDIA/branch-22.02
09a065a 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4555 from NVIDIA/branch-22.02
c129c6a 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4558 from NVIDIA/branch-22.02
f4f199d 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4561 from NVIDIA/branch-22.02
2519afe 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4571 from NVIDIA/branch-22.02
7dc380d 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4574 from NVIDIA/branch-22.02
c8a928b 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4576 from NVIDIA/branch-22.02
61905e0 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4578 from NVIDIA/branch-22.02
a6b6ecc 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4579 from NVIDIA/branch-22.02
09ac41d 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4582 from NVIDIA/branch-22.02
6daf4b1 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4584 from NVIDIA/branch-22.02
f169305 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4586 from NVIDIA/branch-22.02
8ed4e29 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4587 from NVIDIA/branch-22.02
128aeb1 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4590 from NVIDIA/branch-22.02
e9052e3 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4591 from NVIDIA/branch-22.02
b9d0093 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4595 from NVIDIA/branch-22.02
cbc15aa 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4598 from NVIDIA/branch-22.02
21bf4f1 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4601 from NVIDIA/branch-22.02
983680c 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4602 from NVIDIA/branch-22.02
e9aa25c 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4604 from NVIDIA/branch-22.02
d6e5eb7 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nartal1
Make shims.v2.ParquetCachedBatchSerializer as protected (NVIDIA#4560)
a409d0e 
* Change ParquetCachedSerializer and other classes as protected.

Signed-off-by: Niranjan Artal <nartal@nvidia.com>
@andygrove
Implement AST-based regular expression fuzz tests (NVIDIA#4504)
4349acd 
* Regexp AST fuzz test

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* bug fix

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* skip known issues

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* code cleanup and skip some known issues

* remove debug println

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* add more capabilities

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* save progress

* Implement hex and octal generators

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* prepare for review

* update URL for Pattern javadoc
@nvauto
Merge pull request NVIDIA#4607 from NVIDIA/branch-22.02
4747182 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@nvauto
Merge pull request NVIDIA#4620 from NVIDIA/branch-22.02
f95d078 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@NVnavkumar
Adds SQL function HYPOT using the GPU (NVIDIA#4592)
7506ae5 
* Adding GpuHypot class to implement SQL HYPOT function from Spark SQL

Signed-off-by: Navin Kumar <navink@nvidia.com>

* Updated to use improved algorithm that avoids overflow conditions with
squares

Signed-off-by: Navin Kumar <navink@nvidia.com>

* Updated version of GpuHypot using improved algorithm and handle
specific edge cases referred by Java documentation

Signed-off-by: Navin Kumar <navink@nvidia.com>

* Add another comment to clarify use of greatherThan instead of
maxNullAware

Signed-off-by: Navin Kumar <navink@nvidia.com>

* Initial cleanup for SQL HYPOT implementation

Signed-off-by: Navin Kumar <navink@nvidia.com>

* Cleaned up more HYPOT implementation for more optimal memory usage and cleaner code

Signed-off-by: Navin Kumar <navink@nvidia.com>
@pxLi
Update plugin version to 22.04.0-SNAPSHOT (NVIDIA#4597)
85e6640 
* Update plugin version to 22.04.0-SNAPSHOT

Signed-off-by: Peixin Li <pxli@nyu.edu>

* fix copyright and upmerge

* missed comma
@nvauto
Merge pull request NVIDIA#4627 from NVIDIA/branch-22.02
e5bf2ac 
[auto-merge] branch-22.02 to branch-22.04 [skip ci] [bot]
@zhanga5
Enable test results report on Jenkins (NVIDIA#4624)
efeec0d 
Signed-off-by: Alex Zhang <alex4zhang@gmail.com>
jlowe and others added 10 commits February 8, 2022 15:13
@jlowe @sameerz
Add FAQ entry to discuss executor task concurrency configuration [ski…
aa2126d 
…p ci] (NVIDIA#4692)

* Add FAQ entry to discuss executor task concurrency configuration

Signed-off-by: Jason Lowe <jlowe@nvidia.com>

* Update docs/FAQ.md

Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>

Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
@jlowe
Optimize DECIMAL128 sum aggregations [databricks] (NVIDIA#4688)
f3a5cd3 
* Optimize DECIMAL128 sum aggregations

Signed-off-by: Jason Lowe <jlowe@nvidia.com>

* Fix regression in window sum

* Update for review comments

* Explicitly upcast input to avoid libcudf sort-based aggregation issue

* Lower batch limit in agg tests to better exercise sort-based aggregations

* Remove redundant method override
@jlowe
Debug dump to Parquet support for DECIMAL128 columns (NVIDIA#4724)
c8b3917 
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@pxLi
Update centos 8 dockerfile to handle EOL issue [skip ci] (NVIDIA#4709)
7a99707 
* Update centos 8 dockerfile to handle EOL issue

Signed-off-by: Peixin Li <pxli@nyu.edu>

* update copyright
@revans2
Fix failing serializer tests on Spark 3.3.0 (NVIDIA#4732)
ffc18a0 
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@jlowe
Trim join tests to improve runtime of tests (NVIDIA#4731)
9705fab 
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@nartal1
Add tests for few json options (NVIDIA#4698)
667449d 
* add tests for few json options

Signed-off-by: Niranjan Artal <nartal@nvidia.com>

* addressed review comments

Signed-off-by: Niranjan Artal <nartal@nvidia.com>
@gerashegalov
Change resume-from to aggregator in buildall [skip ci] (NVIDIA#4738)
783f841 
Ensure proper spark version classifier profile activation by making aggregator the start of resume-from in the second single-threaded part of the build.

Note that this is a quick fix without much investigation if this is "the right" fix but it works, and should be acceptable for a non-production script. The impact on the build time is negligible

Closes NVIDIA#4736

Signed-off-by: Gera Shegalov gera@apache.org
@jlowe
Check for a null compression codec when creating ORC OutStream (NVIDI…
8608a36 
…A#4737)

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@nvliyuan
fix some broken links in dev branch2204
8796daf 
Signed-off-by: liyuan <yuali@nvidia.com>
@nvliyuan
Copy link
Collaborator Author

fix #4725

@nvliyuan nvliyuan changed the title fix some broken links in dev branch2204 fix some broken links in dev branch2204[skip ci] Feb 10, 2022
@nvliyuan nvliyuan self-assigned this Feb 10, 2022
@nvliyuan
Copy link
Collaborator Author

nvliyuan commented Feb 10, 2022 •
edited
Loading

same changes verified in https://nvliyuan.github.io/yuali-spark-rapids/

@nvliyuan
Copy link
Collaborator Author

sometimes (not always) we will get broken links if we don't put link in a single line.
it is recommended to write [xxx](xxx.md#xxx) in one single line
rather than [xx
x](xxx.md#xx)

@jlowe jlowe added the documentation Improvements or additions to documentation label Feb 10, 2022
@jlowe jlowe added this to the Jan 31 - Feb 11 milestone Feb 10, 2022
jlowe
jlowe reviewed Feb 10, 2022
View reviewed changes
docs/get-started/getting-started-gcp.md
@@ -86,8 +86,8 @@ If you'd like to further accelerate init time to 4-5 minutes, create a custom Da
To use notebooks with a Dataproc cluster, click on the cluster name under the Dataproc cluster tab
and navigate to the "Web Interfaces" tab. Under "Web Interfaces", click on the JupyterLab or
Jupyter link to start to use sample [Mortgage ETL on GPU Jupyter
Notebook](../demo/GCP/Mortgage-ETL-GPU.ipynb) to process full 17 years [Mortgage
data](https://rapidsai.github.io/demos/datasets/mortgage-data).
Notebook](../demo/GCP/Mortgage-ETL-GPU.ipynb) to process full 17 years
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is wrapped as described in the PR description as what should be fixed

docs/tuning-guide.md
@@ -337,7 +337,7 @@ Custom Spark SQL Metrics are available which can help identify performance bottl

Not all metrics are enabled by default. The configuration setting `spark.rapids.sql.metrics.level` can be set
to `DEBUG`, `MODERATE`, or `ESSENTIAL`, with `MODERATE` being the default value. More information about this
configuration option is available in the <a href="configs.md#sql.metrics.level">configuration</a> documentation.
configuration option is available in the [`configuration`](configs.md#sql.metrics.level) documentation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backticks are usually reserved for cases where we are referring to code or things the user should type verbatim. This isn't one of those cases.

Suggested change
configuration option is available in the [`configuration`](configs.md#sql.metrics.level) documentation.
configuration option is available in the [configuration documentation](configs.md#sql.metrics.level).

@sameerz
Copy link
Collaborator

sameerz commented Feb 11, 2022

Good catches!

@viadea
Copy link
Collaborator

viadea commented Feb 11, 2022

@nvliyuan I think we should re-target to 22.02 since 22.02 branch is still open.
Then after that, we should merge it to main and then gh-pages branch.

@nvliyuan nvliyuan changed the base branch from branch-22.04 to branch-22.02 February 11, 2022 01:49
@nvliyuan
Copy link
Collaborator Author

we will target these changes to 22.02 so close this pr and will draft a new one.

@nvliyuan nvliyuan closed this Feb 11, 2022
@nvliyuan nvliyuan mentioned this pull request Feb 11, 2022
Merged
@nvliyuan nvliyuan deleted the fix-broken-links-branch-22.04 branch February 14, 2022 07:35
@pxLi pxLi changed the title fix some broken links in dev branch2204[skip ci] fix some broken links in dev branch-22.02 [skip ci] Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe left review comments

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

@tgravescs tgravescs Awaiting requested review from tgravescs tgravescs is a code owner

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

Assignees

@nvliyuan nvliyuan

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Jan 31 - Feb 11
Development

Successfully merging this pull request may close these issues.