Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease chance of random collisions in test temporary paths #4778

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Feb 14, 2022

Fixes #4749.

Increases the chance of a unique temporary path by adding the process ID as a directory and increasing the range of the generated random number.

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe added the test Only impacts tests label Feb 14, 2022
@jlowe jlowe added this to the Feb 14 - Feb 25 milestone Feb 14, 2022
@jlowe jlowe self-assigned this Feb 14, 2022
@jlowe
Copy link
Member Author

jlowe commented Feb 14, 2022

build

abellina
abellina previously approved these changes Feb 14, 2022
revans2
revans2 previously approved these changes Feb 14, 2022
@jlowe jlowe dismissed stale reviews from revans2 and abellina via 2983ee4 February 14, 2022 21:14
Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gerashegalov
Copy link
Collaborator

build

@jlowe jlowe merged commit c67eedb into NVIDIA:branch-22.04 Feb 15, 2022
@jlowe jlowe deleted the test-tmp-path branch February 15, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] test_write_empty_parquet_round_trip failed
4 participants