Profile tool: fix printing of task failed reason #4848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
|
build |
jlowe
reviewed
Feb 23, 2022
tools/src/test/scala/com/nvidia/spark/rapids/tool/profiling/HealthCheckSuite.scala
Outdated
Show resolved
Hide resolved
…althCheckSuite.scala Co-authored-by: Jason Lowe <jlowe@nvidia.com>
|
build |
jlowe
approved these changes
Feb 23, 2022
nartal1
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the profiling tool task failed table, we were just doing a toString on the task end reason. This caused it to some times have an address in the output and that address could change between runs. Fix it so we use the toErrorString to get the nicely formatted string.