Add Apache Spark 3.1.4-SNAPSHOT Shims #4861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
nartal1
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008 and
NvTimLiu
as code owners
|
@tgravescs Could you please let me know the priority of this over #4857. I can wait until that PR is merged and upmerge my changes to reflect the new design. If we want to enable 3.1.4-SNAPSHOT nightly builds sooner then I think this should be merged earlier. |
|
either way, I think 3.1.4 can wait if the other PR is large |
Thanks for the confirmation. Have marked this PR as draft. Will upmerge once other PR is merged. |
|
Thanks @nartal1 |
|
@nartal1 please update, the other pr has been merged |
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
|
build |
tgravescs
reviewed
Mar 9, 2022
sql-plugin/src/test/314/scala/com/nvidia/spark/rapids/shims/spark314/Spark314ShimsSuite.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
|
build |
tgravescs
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4789.
This PR adds Spark-3.1.4-SNAPSHOT shims. Added test to verify that it works as expected.