Implement percent_rank() on GPU
#4924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by rank and dense_rank Signed-off-by: Navin Kumar <navink@nvidia.com>
revans2
previously approved these changes
Mar 10, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuWindowExpression.scala
Outdated
Show resolved
Hide resolved
|
build |
Signed-off-by: Navin Kumar <navink@nvidia.com>
revans2
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4004.
This implements
percent_rank()on the GPU using CUDF's existingpercentRank()aggregation. However, it does not use the existing batch optimization code because of the non-trivial nature of that potential implementation, combined with the possibility that CUDF will changepercentRank()in the future. Tests have been updated as well to include separate tests forpercent_rank()since they do not use the same optimization, so the check forGpuRunningWindowExecis removed in those cases.I also added decimal 128 support to many of the tests, as this was overlooked in the past since now decimal 128 is supported in partition by.
Signed-off-by: Navin Kumar navink@nvidia.com