Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for the public release [skip ci] #5069

Merged
merged 2 commits into from
Apr 1, 2022
Merged

Update for the public release [skip ci] #5069

merged 2 commits into from
Apr 1, 2022

Conversation

NvTimLiu
Copy link
Collaborator

@NvTimLiu NvTimLiu commented Mar 28, 2022 •
edited
Loading

To fix issue #5050

1, Add JAVA_HOME for maven opt -P source-javadoc

2, Change to use maven opt -P release311 instead of -P release301

3, Add configuration <detectOfflineLinks> for maven-javadoc-plugin:

 Not detecting the links for all modules defined in the project: https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-no-fork-mojo.html#detectOfflineLinks
To fix: [ERROR] `The specified file '/home/jenkins/agent/workspace/jenkins-tim-rapids-release-11/dist/target/rapids-4-spark_2.12-22.04.0.jar' not exists`

Signed-off-by: Tim Liu timl@nvidia.com

@NvTimLiu
Update for the public release
816d4e2 
To fix issue NVIDIA#5050

1, Add JAVA_HOME for maven opt `-P source-javadoc`

2, Change to use maven opt `-P release311` instead of `-P release301`

3, Add configuration `<detectOfflineLinks>` for maven-javadoc-plugin: Not detecting the links for all modules defined in the project: https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-no-fork-mojo.html#detectOfflineLinks
    To [ERROR] `The specified file '/home/jenkins/agent/workspace/jenkins-tim-rapids-release-11/dist/target/rapids-4-spark_2.12-22.04.0.jar' not exists`

Signed-off-by: Tim Liu <timl@nvidia.com>
@NvTimLiu NvTimLiu added the build Related to CI / CD or cleanly building label Mar 28, 2022
@NvTimLiu NvTimLiu self-assigned this Mar 28, 2022
@NvTimLiu
Copy link
Collaborator Author

build

@NvTimLiu NvTimLiu changed the title Update for the public release Update for the public release [skip ci] Mar 28, 2022
@NvTimLiu
Copy link
Collaborator Author

Add [skip ci] as this change only works on release builds/jobs

@NvTimLiu
Copy link
Collaborator Author

build

pxLi
pxLi previously approved these changes Mar 28, 2022
View reviewed changes
res-life
res-life reviewed Mar 28, 2022
View reviewed changes
pom.xml Outdated
@@ -793,6 +793,7 @@
</executions>
<configuration>
<doclint>none</doclint>
<detectOfflineLinks>false</detectOfflineLinks>
Copy link
Collaborator

@res-life res-life Mar 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT:
It's in parent pom, this will effect all the sub-modules.
Currently only the common module and the dist module have problem.
Can we just update these 2 modules?

@tgravescs
Copy link
Collaborator

is the javadoc link error because the integration tests don't generate javadoc then?

@NvTimLiu
Update 'integration-tests/pom.xml' to keep links for all modules defi…
ec8be51 
…ned in the project

Signed-off-by: Tim Liu <timl@nvidia.com>
@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Mar 28, 2022 •
edited
Loading

is the javadoc link error because the integration tests don't generate javadoc then?

integration-test javadoc depends on dist/rapids-4-spark javadoc : https://github.com/NVIDIA/spark-rapids/blob/branch-22.04/integration_tests/pom.xml#L59

dist/rapids-4-spark don't generate the apidocs/javadoc files for leak of dist/src/main/java dir, which makes integration-test FAILED to delete dist/target/apidocs along with jar/sources-jar jars by default detectOfflineLinks=true, (would to re-build them again if successfully invoke javadoc on rapids-4-spark`, but finally it failed).

[INFO] The goal 'org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:javadoc' has not been previously called for the module:
 'com.nvidia:rapids-4-spark_2.12:jar:22.04.0'. Trying to invoke it...
[WARNING] Creating fake javadoc directory to prevent repeated invocations: /spark-rapids/dist/target/apidocs
[ERROR] Error fetching link: /spark-rapids/dist/target/apidocs/package-list. Ignored it.

detectOfflineLinks=false let integration-test not delete dist/rapids-4-sparktarget/apidocs and not invoke jar/sources-jar jars, then the above failure will NOT happen.

@NvTimLiu
Copy link
Collaborator Author

build

NvTimLiu
NvTimLiu commented Mar 30, 2022
View reviewed changes
integration_tests/pom.xml
@@ -344,6 +344,23 @@
</execution>
</executions>
</plugin>
<plugin>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a copy of the parent pom.xml file https://github.com/NVIDIA/spark-rapids/blob/branch-22.04/pom.xml#L782-L797,

Changed nothing but overwrite config: <detectOfflineLinks>false</detectOfflineLinks>

@pxLi pxLi merged commit 679721e into NVIDIA:branch-22.04 Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@res-life res-life res-life left review comments

@pxLi pxLi pxLi approved these changes

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@jlowe jlowe Awaiting requested review from jlowe jlowe is a code owner

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

@tgravescs tgravescs Awaiting requested review from tgravescs tgravescs is a code owner

Assignees

@NvTimLiu NvTimLiu

Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NvTimLiu @tgravescs @pxLi @res-life