Fix issue in GpuArrayExists where a parent view outlived the child #5232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tgravescs @sameerz @jlowe fyi it wasn't a cuDF bug as I originally thought. Should we backport this to 22.04? |
|
build |
jlowe
reviewed
Apr 13, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/higherOrderFunctions.scala
Outdated
Show resolved
Hide resolved
abellina
requested review from
revans2,
tgravescs,
GaryShen2008 and
NvTimLiu
as code owners
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
abellina
force-pushed
the
fix/gpu_array_exists_3vloff_issue
branch
from
d95e8c0
to
d2ab38d
Compare
|
I re-targeted this for 22.04 since it technically is a bug in 22.04 |
jlowe
approved these changes
Apr 13, 2022
|
build |
gerashegalov
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
The change LGTM.
As for 22.04 it is not a high priority because the call path is off by default on Spark 3.x. However, the fix is also very localized to this call path, thus it's a strict improvement without risking to break anything that was not broken before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alessandro Bellina abellina@nvidia.com
Closes #5183.
This fixes a subtle bug with
GpuArrayExists.legacyExiststhat manifests itself with the CUDA async allocator, but is not caused by it.In the old code,
noNullsChildViewwas closed whenreplaceChildNullsByFalseViewreturned, and it was assumed to be a valid child in the calling code (legacyExists). I changed it so this child view is alive and well while we callexistsReduce.Note this seems to me like a bug that exists in 22.04 also.