Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update the ubuntu repo key [skip ci] #5431

Merged
merged 4 commits into from
May 9, 2022

Conversation

viadea
Copy link
Collaborator

@viadea viadea commented May 5, 2022

Update the ubuntu repo key.

Signed-off-by: Hao Zhu <hazhu@nvidia.com>
@viadea viadea added the documentation Improvements or additions to documentation label May 5, 2022
@viadea viadea requested review from tgravescs and sameerz May 5, 2022 18:39
@jlowe jlowe changed the title [Doc]Update the ubuntu repo key[skip ci] [DOC] Update the ubuntu repo key [skip ci] May 5, 2022
jlowe
jlowe previously approved these changes May 5, 2022
@jlowe
Copy link
Member

jlowe commented May 5, 2022

build

Copy link
Collaborator

@sameerz sameerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also update the key in docs/get-started/getting-started-on-prem.md

@@ -26,7 +26,7 @@ readonly CUDA_VERSION
readonly NVIDIA_BASE_DL_URL='https://developer.download.nvidia.com/compute'
# Parameters for NVIDIA-provided Ubuntu GPU driver
readonly NVIDIA_UBUNTU_REPOSITORY_URL="${NVIDIA_BASE_DL_URL}/cuda/repos/ubuntu1804/x86_64"
readonly NVIDIA_UBUNTU_REPOSITORY_KEY="${NVIDIA_UBUNTU_REPOSITORY_URL}/7fa2af80.pub"
readonly NVIDIA_UBUNTU_REPOSITORY_KEY="${NVIDIA_UBUNTU_REPOSITORY_URL}/3bf863cc.pub"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update our instructions per https://forums.developer.nvidia.com/t/notice-cuda-linux-repository-key-rotation/212772#install-new-cuda-keyring-package-3 , since it appears that manually installing a new signing key is not preferred?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can do that. Let me firstly submit GoogleCloudDataproc/initialization-actions#995 to change in GCP repo for this.

Let me move this PR to draft firstly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sameerz @jlowe I just updated this PR:

  1. Use latest CUDA 11.6 on Ubuntu 20.04 instructions in the doc since we want users to use latest CUDA for on-prem installation.
  2. Changed NVIDIA_UBUNTU_REPOSITORY to NVIDIA_UBUNTU_REPO to match GCP PR-991.
  3. Use the key package way to install key.

@sameerz sameerz added this to the May 2 - May 20 milestone May 6, 2022
Signed-off-by: Hao Zhu <hazhu@nvidia.com>
Signed-off-by: Hao Zhu <hazhu@nvidia.com>
Signed-off-by: Hao Zhu <hazhu@nvidia.com>
@sameerz
Copy link
Collaborator

sameerz commented May 9, 2022

build

@sameerz sameerz merged commit b774bf5 into NVIDIA:branch-22.06 May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants