Fallback parquet reading with merged schema and native footer reader #5500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
|
Can we please just disable the test temporarily instead? The NATIVE footer parser is experimental so anyone using it is taking a risk. This stops the test from failing but does not fix any underlying issues. |
|
@sperlingxx did you reproduce the failure? How does does the native footer lead to an overflow? |
|
Hi @revans2, I didn't reproduce it. I am sorry that I came to this conclusion too hurriedly. |
revans2
approved these changes
May 18, 2022
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the test to not fail for #5493
Native footer reader for parquet fetches data fields totally based on read schema, which may lead to overflow if merge schema is enabled. When merge schema is enabled, the file schema of each file partition may not contain the complete (read) schema. In this situation, native footer reader will come up with incorrect footers.
To prevent this situation, we fallback the parquet reading to CPU if merge schema and native footer reader are both enabled.