Address feedback in "string anchors regexp replace" PR #5519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
force-pushed
the
string_anchors_regexp_replace-address-feedback
branch
from
d48d432
to
d6da643
Compare
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
force-pushed
the
string_anchors_regexp_replace-address-feedback
branch
from
e7f99b3
to
1df80f1
Compare
andygrove
changed the title
revans2
approved these changes
May 18, 2022
|
build |
sameerz
added
the
task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on PR to #5491 to address some review feedback items.
Changes in this PR:
transpilereturn type so that first item in tuple is no longer an option._1when processing result of callingtranspile