Fix tests failing on Spark 3.1 #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
jlowe
added
test
|
build |
revans2
approved these changes
Aug 14, 2020
tgravescs
reviewed
Aug 14, 2020
| longsFromCSVDf, conf = floatAggConf) { | ||
| frame => val res = frame.selectExpr("avg(distinct longs) filter (where longs < 5)") | ||
| res | ||
| if (spark.SPARK_VERSION_SHORT < "3.1.0") { |
There was a problem hiding this comment.
this is fine but we had added a function to the shim layer to get the version so that we could handle different shim layers in addition to apache versions. There is one test using it already, it would be nice to stay consistent (see StringFallbackSuite):
val isValidTestForSparkVersion = ShimLoader.getSparkShims.getSparkShimVersion match {
case SparkShimVersion(major, minor, _) => major == 3 && minor == 0
case DatabricksShimVersion(major, minor, _) => major == 3 && minor == 0
case _ => true
}
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#557) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of Scala tests that were failing on Spark 3.1.0-SNAPSHOT.
One of the tests was relying on a
ProjectExecto work correctly, and Spark 3.1.0 optimized it out. I added an explicit project after the filter to work around it.The other test failed because something that doesn't work in Spark 3.0 now works in Spark 3.1. Updated the test to check the Spark version before deciding what kind of test to run.