Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Databricks build scripts [databricks] #5588

Merged
merged 3 commits into from
May 24, 2022
Merged

Update Databricks build scripts [databricks] #5588

merged 3 commits into from
May 24, 2022

Commits on May 23, 2022

  1. Update Databricks build scripts [databricks] 

    1, Change unused Databricks build parameter `build_profiles` to `mvn_opt`, will re-use mvn_opt as maven options, e.g. mvn_opt='-Dspark-rapids-jnv.version=22.06.0-SNAPSHOT'

2, There would be parameters mismatching issue for the script build.sh, if empty parameters are used, or if one of the parameters are missing. e.g. "build.sh param1  'blankspace'  param3  would be treat as "build.sh param1   param2"

To avoid this mismatching, pass parameters through shell environment for the script file build.sh instead, e.g.,
SPARK_VER=3.1.2 MVN_OPT=' ' SOURCE_FILE=spark-rapids.tgz bash build.sh

3, remove unused `build_profiles` parameter from Jenkinsfile-blossom.premerge

Signed-off-by: Tim Liu <timl@nvidia.com>
    @NvTimLiu
    NvTimLiu committed May 23, 2022
    Configuration menu
    Copy the full SHA
    388e284 View commit details
    Browse the repository at this point in the history

  2. update

    @NvTimLiu
    NvTimLiu committed May 23, 2022
    Configuration menu
    Copy the full SHA
    b67407a View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. update using long parameter '--mvnoptions'

    @NvTimLiu
    NvTimLiu committed May 24, 2022
    Configuration menu
    Copy the full SHA
    11f232b View commit details
    Browse the repository at this point in the history