Enable regular expressions by default #5591
Conversation
Signed-off-by: Andy Grove <andygrove@nvidia.com>
| "true will make supported regular expressions run on the GPU. See the compatibility " + | ||
| "guide for more information about which regular expressions are supported on the GPU.") | ||
| .doc("Specifies whether supported regular expressions should be evaluated on GPU. There " + | ||
| "are some known edge cases that can produce incorrect results and these are documented in " + |
There was a problem hiding this comment.
should this say that known edge cases are executed on CPU regardless of the config value, at least this is the impression I have from reading compatibility guide.
| "true will make supported regular expressions run on the GPU. See the compatibility " + | ||
| "guide for more information about which regular expressions are supported on the GPU.") | ||
| .doc("Specifies whether supported regular expressions should be evaluated on GPU. There " + | ||
| "are some known edge cases that can produce incorrect results and these are documented in " + |
There was a problem hiding this comment.
should this say that known edge cases are executed on CPU, at least this is the impression I have from reading compatibility guide.
|
I agree with @gerashegalov 's comments, and am ok with the rest of the text wording. |
|
I had been holding off updating this in the hope that #5610 and #5662 would be merged and then we would not need to list any known issues in this PR. However, I am blocked from merging those at the moment due to the need to have CI specify |
andygrove
changed the title
|
build |
|
build |
Signed-off-by: Andy Grove andygrove@nvidia.com
Part of #4509
We want to enable regular expressions by default in 22.06. This does not mean we are guaranteeing 100% compatibility with Spark though so we need to document the edge cases that can produce different results.
true