Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip unshim and dedup of external spark-rapids-jni and jucx [databricks] #5603
Skip unshim and dedup of external spark-rapids-jni and jucx [databricks] #5603
Changes from 1 commit
99bf60a
35c75dd
0e5192c
ea15cd8
0c7047f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To have a more obvious way of reasoning about the order of the dependency processing I would move this unpacks inside ant
build-parallel-worlds.xml
tocopy-dependencies
target either before or after the for loop.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not found a way to invoke the
unpack
goal ofmaven-dependency-plugin
in themaven-antrun-plugin
.Just coping the jars in the local
~/.m2
path is not so good, because we can specify the local repository path when executingmvn
commands. Themaven-dependency-plugin
is responsible to copy the right jars.Now the
unpack
works and the order is right, let's keep it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can be done similar to the dependency:get code there.
Your suggestion is fine with me, however, I am biased to keeping related code in one place even if it's a little hacky.