Fix GpuCast losing the timezoneId during canonicalization #5713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
|
build |
jbrennan333
approved these changes
Jun 2, 2022
sameerz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5670
The timezoneid setting was being lost during canonicalization on GpuCast which ultimately caused a parse error to occur because during plan canonicalization we end up trying to access a canoncialized Alias which will end up trying to do a parse if it is not resolved. The GpuCast wasn't resolved because it didn't have the timezone id.
The fix is straight forward and we had a comment there to add in the needsTimeZone check. Basically we were intentionally nulling it out when we shouldn't have been because we weren't checking needsTimeZone
I want to try to add a test case to the integration tests but need to find minimal repro cast, putting up here for early review and run tests and get in asap. I can always followup with test.
Signed-off-by: Thomas Graves tgraves@nvidia.com