Fix data size metric always 0 when using RAPIDS shuffle #603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #511.
This connects the existing
dataSize
metric to the RAPIDS shuffle. In the legacy shuffle this metric is updated via the serializer, but using the RAPIDS shuffle side-steps the serializer and thus the metric never is set.This approach puts the metric into the shuffle dependency, and then the metric is passed to to the RAPIDS shuffle writer when it is constructed.