[FEA] Add signoff check to gh-pages #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the plan to move the existing sign-off check on the dev branches to Github actions as well? It's a maintenance burden to be doing it two different ways. |
Yeah, that's my plan here if this one looks good. So we are trying to use Github actions in all trivial GitHub-related workflows if possible. And our internal Jenkins will be a dedicated service for our building and testing since it requires GPU resources |
jlowe
approved these changes
Aug 28, 2020
sameerz
approved these changes
Aug 28, 2020
|
I added the signoff-check to the |
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
[auto-merge] bot-auto-merge-branch-22.10 to branch-22.12 [skip ci] [bot]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #604
After this got merged, we should update branch rule on
gh-pagesto enable this check.e.g.