Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added in very specific support for from_json to a Map<String,String> #6211

Merged
merged 5 commits into from
Aug 4, 2022
Merged

Added in very specific support for from_json to a Map<String,String> #6211

merged 5 commits into from
Aug 4, 2022

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Aug 3, 2022

This depends on rapidsai/cudf#11431

@revans2
Added in very specific support for from_json to a Map<String,String>
04bd3e3 
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@revans2 revans2 added feature request New feature or request SQL part of the SQL/Dataframe plugin cudf_dependency An issue or PR with this label depends on a new feature in cudf labels Aug 3, 2022
@revans2 revans2 added this to the July 22 - Aug 5 milestone Aug 3, 2022
@revans2 revans2 self-assigned this Aug 3, 2022
@revans2 revans2 marked this pull request as draft August 3, 2022 13:59
jlowe
jlowe reviewed Aug 3, 2022
View reviewed changes
docs/configs.md Outdated Show resolved Hide resolved
jlowe
jlowe previously approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small capitalization nit, lgtm.

sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala Outdated Show resolved Hide resolved
jlowe
jlowe previously approved these changes Aug 3, 2022
View reviewed changes
@sameerz sameerz mentioned this pull request Aug 4, 2022
Merged
@revans2 revans2 marked this pull request as ready for review August 4, 2022 13:59
@revans2
Copy link
Collaborator Author

revans2 commented Aug 4, 2022

build

@revans2
Copy link
Collaborator Author

revans2 commented Aug 4, 2022

build

@revans2
Copy link
Collaborator Author

revans2 commented Aug 4, 2022

@jlowe please take another look. I had to upmerge to fix a small issue with auto-generated documentation that didn't auto-merge correctly.

@sameerz
Copy link
Collaborator

sameerz commented Aug 4, 2022

build

@revans2 revans2 merged commit 8b497c5 into NVIDIA:branch-22.10 Aug 4, 2022
@revans2 revans2 deleted the from_json_experiment branch August 4, 2022 18:35
revans2 added a commit to revans2/spark-rapids that referenced this pull request Sep 6, 2022
@revans2
Revert "Added in very specific support for from_json to a Map<String,…
76d78fa 
…String> (NVIDIA#6211)"

This reverts commit 8b497c5.
revans2 added a commit that referenced this pull request Sep 7, 2022
@revans2
Revert "Added in very specific support for from_json to a Map<String,…
1bcef3a 
…String> (#6211)" (#6510)

This reverts commit 8b497c5.

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@ttnghia ttnghia mentioned this pull request Dec 28, 2022
Merged
@ttnghia ttnghia mentioned this pull request Jan 11, 2023
Merged
@cindyyuanjiang cindyyuanjiang mentioned this pull request Apr 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees

@revans2 revans2

Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request SQL part of the SQL/Dataframe plugin
Projects
None yet
Milestone
July 22 - Aug 5
Development

Successfully merging this pull request may close these issues.
3 participants
@revans2 @sameerz @jlowe