Copy function isSearchableType from Spark because signature changed in 3.0.1 #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3.0.1 Signed-off-by: Thomas Graves <tgraves@nvidia.com>
|
build |
jlowe
added
bug
jlowe
approved these changes
Aug 31, 2020
|
test failure is in Pspark310tests. Looks like spark 3.1.0 changed something unrelated - apache/spark@806140d |
|
build |
pxLi
pushed a commit
to pxLi/spark-rapids
that referenced
this pull request
Sep 1, 2020
NVIDIA#632) 3.0.1 Signed-off-by: Thomas Graves <tgraves@nvidia.com> Co-authored-by: Thomas Graves <tgraves@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
NVIDIA#632) 3.0.1 Signed-off-by: Thomas Graves <tgraves@nvidia.com> Co-authored-by: Thomas Graves <tgraves@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
NVIDIA#632) 3.0.1 Signed-off-by: Thomas Graves <tgraves@nvidia.com> Co-authored-by: Thomas Graves <tgraves@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark backported a change for ORC predicate pushdown should work with case-insensitive analysis:
apache/spark@6c88d7c
This broke the plugin with Spark 3.0.1 because they changed the isSearchableType from protected to private. To fix for now copy that function into our source base.
I had already filed an issue to fix this for Spark 3.1.0 with issue: #576. So we can add support for 3.0.1 under that as well. I figured that could wait for 0.3 but if we want this sooner we should change target of it.
Signed-off-by: Thomas Graves tgraves@nvidia.com