Add Parquet-based cache serializer #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
|
build |
revans2
reviewed
Sep 2, 2020
shims/spark300/src/main/scala/com/nvidia/spark/rapids/shims/spark300/Spark300Shims.scala
Outdated
Show resolved
Hide resolved
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Outdated
Show resolved
Hide resolved
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Outdated
Show resolved
Hide resolved
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Outdated
Show resolved
Hide resolved
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Show resolved
Hide resolved
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Outdated
Show resolved
Hide resolved
shims/spark310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/Spark310Shims.scala
Outdated
Show resolved
Hide resolved
...park310/src/main/scala/org/apache/spark/sql/rapids/shims/spark310/GpuColumnarToRowExec.scala
Outdated
Show resolved
Hide resolved
...310/src/main/scala/org/apache/spark/sql/rapids/shims/spark310/GpuInMemoryTableScanExec.scala
Outdated
Show resolved
Hide resolved
...310/src/main/scala/org/apache/spark/sql/rapids/shims/spark310/GpuInMemoryTableScanExec.scala
Outdated
Show resolved
Hide resolved
|
I forgot that we also need some updates to the documentation to be able to explain that this exists, but only for 3.1.0, that it is still in preview etc. |
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Do we need to update any of our 0.2 documentation? |
|
I would like some docs, but because 3.1 will not be part of the official release jars I'm not sure it is going to make that much of a difference because the user would have to build it themselves. |
revans2
reviewed
Sep 8, 2020
shims/spark301/src/main/scala/com/nvidia/spark/rapids/shims/spark301/Spark301Shims.scala
Outdated
Show resolved
Hide resolved
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Outdated
Show resolved
Hide resolved
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Outdated
Show resolved
Hide resolved
shims/spark310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/Spark310Shims.scala
Outdated
Show resolved
Hide resolved
|
@revans2 I think all your concerns have been addressed. PTAL |
revans2
previously approved these changes
Sep 8, 2020
|
build |
|
@revans2 fixed the assert. I know you said it was minor but I still went ahead and fixed it. Please approve again |
revans2
approved these changes
Sep 8, 2020
|
build |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* upmerged * Pluggable cache using parquet to compress/decompress * test change needed for running with the serializer * Added GpuInMemoryTableScanExec * add 3.1 dependency * cache plugin with shims * Tagged RowToColumnar * cleaning up the TransitionOverrides Signed-off-by: Raza Jafri <rjafri@nvidia.com> * cleanup Signed-off-by: Raza Jafri <rjafri@nvidia.com> * review changes Signed-off-by: Raza Jafri <rjafri@nvidia.com> * only read necessary columns * missing configs.md * regenerated configs.md * addressed review comments * fix the assert Co-authored-by: Raza Jafri <rjafri@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* upmerged * Pluggable cache using parquet to compress/decompress * test change needed for running with the serializer * Added GpuInMemoryTableScanExec * add 3.1 dependency * cache plugin with shims * Tagged RowToColumnar * cleaning up the TransitionOverrides Signed-off-by: Raza Jafri <rjafri@nvidia.com> * cleanup Signed-off-by: Raza Jafri <rjafri@nvidia.com> * review changes Signed-off-by: Raza Jafri <rjafri@nvidia.com> * only read necessary columns * missing configs.md * regenerated configs.md * addressed review comments * fix the assert Co-authored-by: Raza Jafri <rjafri@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#638) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers the Cache plug which converts
ColumnarBatch/InternalRowtoParquetCachedBatch. When cache is read back, the batch is converted toColumnarBatchand left on the GPU when its performant to do so.Currently working on writing a simple test that will allow us to quickly know if the serializer is being picked up by Spark session or not. That will come as a follow-on work as well unless this is still pending.
There is still a lot to be done, this is a first step in the right direction