-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix verify build after integration tests are run #657
Conversation
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
build |
Removing these directories would be a nasty surprised to anyone who ran spark from the top of the plugin repo. Granted may not be a common thing, but still destruction of data the tests didn't necessarily create. It would be preferable to have the integration tests run from a directory somewhere underneath |
This script only works being run from the main test directory. So having someone try to run this script from another directory already will run into issues with not being able to find dependencies. Which because of the I can try to play around with some things in pytest, but generally pytest assumes that you are running from the base directory with how it tries to play games with importing things. |
build |
@jlowe the tests now run in a sub-directory of target by default. |
* Fix leaked files Signed-off-by: Robert (Bobby) Evans <bobby@apache.org> * Addressed review comments * Cleanup
* Fix leaked files Signed-off-by: Robert (Bobby) Evans <bobby@apache.org> * Addressed review comments * Cleanup
Signed-off-by: Peixin Li <pxli@nyu.edu> Signed-off-by: Peixin Li <pxli@nyu.edu>
Not perfect but tries to deal with fixing some issues with hive metastore files in the integration tests.
This fixes #656