Flatten simple 4+ nesting of withResource #6833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NVIDIA#6758 after inspecting the result of a multiline regex search ``` (.*withResource.*[\n]){4,} ``` under modules src/main Signed-off-by: Gera Shegalov <gera@apache.org>
gerashegalov
added
the
task
|
build |
|
We should remove the "Fixes" action in the description, as I know there are other places that we also need to fix before we close the main issue. Perhaps "Contributes" or break up as a sub-issue and we can then have this PR close that. |
|
@gerashegalov could you please add to the description information about the new lazy resource interface that is being proposed in your PR? |
abellina
reviewed
Oct 18, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCSVScan.scala
Outdated
Show resolved
Hide resolved
abellina
reviewed
Oct 18, 2022
sql-plugin/src/main/330+/scala/com/nvidia/spark/rapids/shims/GpuIntervalUtils.scala
Outdated
Show resolved
Hide resolved
|
build |
1 similar comment
|
build |
jlowe
reviewed
Oct 18, 2022
sql-plugin/src/main/330+/scala/com/nvidia/spark/rapids/shims/GpuIntervalUtils.scala
Outdated
Show resolved
Hide resolved
|
build |
abellina
reviewed
Oct 19, 2022
sql-plugin/src/main/330+/scala/com/nvidia/spark/rapids/shims/GpuIntervalUtils.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Show resolved
Hide resolved
Signed-off-by: Gera Shegalov <gera@apache.org>
Signed-off-by: Gera Shegalov <gera@apache.org>
Signed-off-by: Gera Shegalov <gera@apache.org>
|
build |
|
build |
1 similar comment
|
build |
abellina
previously approved these changes
Oct 24, 2022
jlowe
reviewed
Oct 24, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCast.scala
Outdated
Show resolved
Hide resolved
|
build |
…nto reduceWithResourceScope
|
build |
|
build |
|
build |
jlowe
approved these changes
Oct 25, 2022
abellina
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #6758 after inspecting the result of a multiline regex search
under modules src/main
Signed-off-by: Gera Shegalov gera@apache.org