Reduce memory usage in aggregate.scala #6859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
abellina
added
the
reliability
jlowe
reviewed
Oct 19, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/aggregate.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/aggregate.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/aggregate.scala
Outdated
Show resolved
Hide resolved
revans2
reviewed
Oct 19, 2022
| val isLastInputBatch = GpuColumnVector.isTaggedAsFinalBatch(childBatch) | ||
| val aggBatch = computeAggregateAndClose(childBatch, aggHelper) | ||
|
|
||
| val spillableBatch = withResource(aggBatch) { _ => |
There was a problem hiding this comment.
nit: why not just combine these two lines?
val spillableBatch = withResource(computeAggregateAndClose(childBatch, aggHelper)) { aggBatch =>
|
|
||
| // a post-processing step required in some scenarios, casting or picking | ||
| // apart a struct | ||
| helper.postProcess(aggregated) |
There was a problem hiding this comment.
It feels rather inconsistent that postProcess closes the aggregated batch, but preProcess does not. This is not new, but it might be nice to rename postProcess to indicate that it closes the batch.
There was a problem hiding this comment.
made neither close the batch, so the names stay the same. Please see cbbbf6b.
|
build |
jlowe
approved these changes
Oct 19, 2022
|
This PR failed on this unrelated issue: #6865 |
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alessandro Bellina abellina@nvidia.com
This PR contributes to #6758. It reduces the amount of outstanding memory by un-nesting
withResourceusage in a few key places where memory was being kept alive unnecessarily.