Stop removing GpuCoalesceBatches from non-AQE queries when AQE is enabled #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… AQE is enabled Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
changed the title
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
andygrove
changed the title
|
build |
|
The scala tests failed this time against spark 3.0.1 and I cannot reproduce locally. |
|
build |
andygrove
changed the title
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
jlowe
reviewed
Sep 10, 2020
docs/configs.md
Outdated
| @@ -57,7 +57,7 @@ Name | Description | Default Value | |||
| <a name="sql.format.parquet.enabled"></a>spark.rapids.sql.format.parquet.enabled|When set to false disables all parquet input and output acceleration|true | |||
| <a name="sql.format.parquet.multiThreadedRead.enabled"></a>spark.rapids.sql.format.parquet.multiThreadedRead.enabled|When set to true, reads multiple small files within a partition more efficiently by reading each file in a separate thread in parallel on the CPU side before sending to the GPU. Limited by spark.rapids.sql.format.parquet.multiThreadedRead.numThreads and spark.rapids.sql.format.parquet.multiThreadedRead.maxNumFileProcessed|true | |||
| <a name="sql.format.parquet.multiThreadedRead.maxNumFilesParallel"></a>spark.rapids.sql.format.parquet.multiThreadedRead.maxNumFilesParallel|A limit on the maximum number of files per task processed in parallel on the CPU side before the file is sent to the GPU. This affects the amount of host memory used when reading the files in parallel.|2147483647 | |||
| <a name="sql.format.parquet.multiThreadedRead.numThreads"></a>spark.rapids.sql.format.parquet.multiThreadedRead.numThreads|The maximum number of threads, on the executor, to use for reading small parquet files in parallel.|20 | |||
| <a name="sql.format.parquet.multiThreadedRead.numThreads"></a>spark.rapids.sql.format.parquet.multiThreadedRead.numThreads|The maximum number of threads, on the executor, to use for reading small parquet files in parallel. This can not be changed at runtime after the executor hasstarted.|20 | |||
There was a problem hiding this comment.
This indicates the branch needs to be upmerged/rebased on latest branch-0.2.
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
changed the title
|
build |
|
Status update: I have manually tested this by running TPC-DS benchmarks and confirming no regressions in performance (with our derived TPC-DS benchmarks, so no DPP involved). |
jlowe
approved these changes
Sep 11, 2020
revans2
approved these changes
Sep 11, 2020
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…bled (NVIDIA#720) * Fix bug where GpuCoalesceBatches is removed from non-AQE queries when AQE is enabled Signed-off-by: Andy Grove <andygrove@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…bled (NVIDIA#720) * Fix bug where GpuCoalesceBatches is removed from non-AQE queries when AQE is enabled Signed-off-by: Andy Grove <andygrove@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
[auto-merge] bot-auto-merge-branch-22.12 to branch-23.02 [skip ci] [bot]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Grove andygrove@nvidia.com
GpuTransitionOverrideshas special handling for adaptive queries, whereGpuCoalesceBatchesis removed from aGpuShuffleExchangeExecand re-inserted around theGpuCustomShuffleReader. See comments in this PR for a more detailed explanation.The bug here though was that we assumed all queries where adaptive queries when AQE is enabled, and there are cases where queries are not adaptive (such as when dynamic partition pruning is used) and this resulted in the plugin removing the
GpuCoalesceBatchesoperator and not inserting it again (because there was noGpuCustomShuffleReader) and this results in poor performance.This closes #698