Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code coverage to find source files in new places #723

Merged
merged 3 commits into from
Sep 15, 2020
Merged

Update code coverage to find source files in new places #723

merged 3 commits into from
Sep 15, 2020

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Sep 10, 2020

I noticed that code coverage was not good for the UDF compiler, and that the source files were not being picked up either.
This hopefully fixes the later problem, for the former one I'm not sure if it was that the tests were not being picked up properly or if the coverage is really just not great. Once I know this works.

@revans2
Update code coverage to find source files in new places
816791d 
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@revans2
Copy link
Collaborator Author

revans2 commented Sep 10, 2020

build

@revans2 revans2 changed the title [WIP] Update code coverage to find source files in new places Update code coverage to find source files in new places Sep 10, 2020
@revans2
Copy link
Collaborator Author

revans2 commented Sep 10, 2020

Yup the code coverage is accurate, we just need to spend some time on making it better. The source files are now captured.

@revans2 revans2 self-assigned this Sep 10, 2020
@revans2 revans2 added build Related to CI / CD or cleanly building bug Something isn't working labels Sep 10, 2020
@revans2 revans2 added this to the Aug 31 - Sep 11 milestone Sep 10, 2020
@revans2
Copy link
Collaborator Author

revans2 commented Sep 10, 2020

I targeted this to 0.2, but it is minor and could easily be in 0.3 if needed.

jlowe
jlowe previously approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this going into 0.2 since it doesn't affect the main build but only the code coverage build and is arguably a bugfix.

@abellina abellina mentioned this pull request Sep 10, 2020
Open
@abellina
Copy link
Collaborator

abellina commented Sep 10, 2020 •
edited
Loading

So this PR didn't fix the problem right? I don't think it hurts to merge, just making sure i understand. I filed this one for the UDF compiler coverage issue: #728

pxLi
pxLi reviewed Sep 11, 2020
View reviewed changes
Copy link
Collaborator

@pxLi pxLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also make a change to https://github.com/NVIDIA/spark-rapids/blob/branch-0.2/jenkins/Jenkinsfile-blossom.premerge#L238? The old premerge pipeline will be retired after 0.2 release, so during this period we have do it in 2 places before we sunset the old one.

But I can make another PR if you want

@revans2
Copy link
Collaborator Author

revans2 commented Sep 11, 2020

@pxLi great catch.

@revans2
Copy link
Collaborator Author

revans2 commented Sep 11, 2020

build

jlowe
jlowe previously approved these changes Sep 11, 2020
View reviewed changes
abellina
abellina previously approved these changes Sep 11, 2020
View reviewed changes
@pxLi
Copy link
Collaborator

pxLi commented Sep 14, 2020

build

@pxLi pxLi mentioned this pull request Sep 14, 2020
Merged
@revans2 revans2 changed the base branch from branch-0.2 to branch-0.3 September 14, 2020 13:48
@revans2 revans2 dismissed stale reviews from abellina and jlowe September 14, 2020 13:48

The base branch was changed.

@revans2
Copy link
Collaborator Author

revans2 commented Sep 14, 2020

build

@revans2 revans2 merged commit 3c226d5 into NVIDIA:branch-0.3 Sep 15, 2020
@revans2 revans2 deleted the fix-code-coverage branch September 15, 2020 17:44
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@revans2
Update code coverage to find source files in new places (NVIDIA#723)
b6326b1 
* Update code coverage to find source files in new places

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@revans2
Update code coverage to find source files in new places (NVIDIA#723)
b225f49 
* Update code coverage to find source files in new places

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
@pxLi
Init 23.02.0 (NVIDIA#723)
6c322c3 
* Init 23.02.0

Signed-off-by: Peixin Li <pxli@nyu.edu>

* target submodule to cudf branch-23.02

Signed-off-by: Peixin Li <pxli@nyu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxLi pxLi pxLi left review comments

@jlowe jlowe jlowe approved these changes

@abellina abellina abellina left review comments

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

@tgravescs tgravescs Awaiting requested review from tgravescs tgravescs is a code owner

Assignees

@revans2 revans2

Labels
bug Something isn't working build Related to CI / CD or cleanly building
Projects
None yet
Milestone
Sep 14 - Sep 25
Development

Successfully merging this pull request may close these issues.
5 participants
@revans2 @abellina @pxLi @jlowe @sameerz