Support Float order-by columns for RANGE window functions [databricks] #8637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on rapidsai/cudf#13635. This commit adds support for floating point order-by columns in RANGE based window functions. Prior to this commit, when the `GpuWindowExec` was presented with an order-by column of floating-point type, the entire window operation would fall back to CPU execution. This should now execute entirely on the GPU. Example query: ```sql SELECT COUNT(1) OVER (PARTITION BY grp ORDER BY float_column RANGE BETWEEN 1.023 PRECEDING AND 3.14159 FOLLOWING) FROM my_float_table; ``` Signed-off-by: MithunR <mythrocks@gmail.com>
mythrocks
force-pushed
the
window-float-oby
branch
from
b8fbd47
to
d15c83c
Compare
|
We cannot run CI until rapidsai/cudf#13635 is merged. This is guaranteed to fail otherwise. |
|
Build |
revans2
previously approved these changes
Jul 6, 2023
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuWindowExpression.scala
Outdated
Show resolved
Hide resolved
mythrocks
changed the title
|
Build |
revans2
approved these changes
Jul 10, 2023
|
Thank you for the review, @revans2. I've merged this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7801.
Depends on rapidsai/cudf#13635.
This commit adds support for floating point order-by columns in RANGE based window functions.
Prior to this commit, when the
GpuWindowExecwas presented with an order-by column of floating-point type, the entire window operation would fall back to CPU execution. This should now execute entirely on the GPU.Example query: