Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write InternalRow to CachedBatch #914

Merged
merged 9 commits into from
Oct 21, 2020

Conversation

razajafri
Copy link
Collaborator

This PR writes InternalRows to CachedBatches

The one thing that I know sticks out in this PR is that we are using a deprecated constructor in ParquetRecordWriter.

Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri razajafri changed the title Write InternalRow to CachedBatch [REVIEW] Write InternalRow to CachedBatch Oct 7, 2020
@razajafri
Copy link
Collaborator Author

build

@sameerz sameerz added the performance A performance related task/issue label Oct 9, 2020
@jlowe jlowe changed the title [REVIEW] Write InternalRow to CachedBatch Write InternalRow to CachedBatch Oct 9, 2020
@sameerz sameerz added this to the Oct 12 - Oct 23 milestone Oct 10, 2020
@razajafri
Copy link
Collaborator Author

@jlowe can you take another look?

@revans2 do you have any concerns?

@razajafri
Copy link
Collaborator Author

build

1 similar comment
@razajafri
Copy link
Collaborator Author

build

@razajafri
Copy link
Collaborator Author

build

@jlowe
Copy link
Member

jlowe commented Oct 20, 2020

build

@razajafri
Copy link
Collaborator Author

build

@razajafri
Copy link
Collaborator Author

build

@razajafri razajafri merged commit 8fe81e7 into NVIDIA:branch-0.3 Oct 21, 2020
sperlingxx pushed a commit to sperlingxx/spark-rapids that referenced this pull request Nov 20, 2020
* This PR writes the InternalRow to a CachedBatch using the RecordWriter. This parquet file is an in-memory file and is saved as buffers inside a CachedBatch.
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* This PR writes the InternalRow to a CachedBatch using the RecordWriter. This parquet file is an in-memory file and is saved as buffers inside a CachedBatch.
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* This PR writes the InternalRow to a CachedBatch using the RecordWriter. This parquet file is an in-memory file and is saved as buffers inside a CachedBatch.
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
…IDIA#914)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance A performance related task/issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants