Refactor Parquet readers [databricks] #9631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
# Conflicts: # sql-plugin/src/main/scala/com/nvidia/spark/RebaseHelper.scala # sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuParquetScan.scala
ttnghia
added
the
task
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
|
build |
jlowe
reviewed
Nov 3, 2023
sql-plugin/src/main/java/com/nvidia/spark/rapids/iceberg/parquet/GpuParquetReader.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
ttnghia
force-pushed
the
refactor_parquet_scan
branch
from
293e27c
to
63342a9
Compare
|
build |
|
build |
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
ttnghia
force-pushed
the
refactor_parquet_scan
branch
from
00aa22d
to
1b464ec
Compare
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
|
build |
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
|
build |
|
CI tests fail due to something else, which will be fixed by #9641. |
# Conflicts: # sql-plugin/src/main/scala/com/nvidia/spark/RebaseHelper.scala # sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuParquetScan.scala
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
|
build |
jlowe
reviewed
Nov 6, 2023
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuParquetFileFormat.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/datetimeRebaseUtils.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/datetimeRebaseUtils.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/datetimeRebaseUtils.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/datetimeRebaseUtils.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/datetimeRebaseUtils.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/datetimeRebaseUtils.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/datetimeRebaseUtils.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Nghia Truong <nghiat@nvidia.com> # Conflicts: # sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuParquetScan.scala
|
Looks like latest commit does not build? |
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Sorry there were some small build issues. Now they're fixed. |
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
jlowe
previously approved these changes
Nov 6, 2023
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuParquetScan.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
|
build |
jlowe
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the current Parquet readers, mostly modifying the variables to store datetime rebase modes. In particular, it changes from the boolean variables
isCorrectedRebaseModeandisCorrectedInt96RebaseModeinto strong type variablesdateRebaseModeandtimestampRebaseMode. This allows the readers to later check if the rebase mode is any of the optionsEXCEPTION,LEGACYandCORRECTED.Depends on: